fix(service): allow fastly service version validate to use FASTLY_SERVICE_ID env fallback - #1907
Merged
jedisct1 merged 3 commits intoSep 21, 2026
Conversation
Contributor
|
Thanks for your contribution. Cab you add a - fix(service): allow `service version validate` to use `FASTLY_SERVICE_ID`.? Also, maybe renamed “missing service ID” test should explicitly set: EnvVars: map[string]string{"FASTLY_SERVICE_ID": ""},Thank you! |
Contributor
Author
|
Thanks! I’ll make the requested changes and push an update shortly. |
4 tasks
Member
|
Hi @Tyagiquamar - thanks for your contribution! Please use our PR template for the initial description. |
Contributor
Author
|
Updated the PR description to match the template. Both the changelog entry and the explicit empty env test have also been added. |
Contributor
Author
|
Hi @jedisct1, friendly ping when you have a moment. The PR template, changelog entry, and explicit empty env test have all been added, and CI checks are passing. Thanks! |
…VICE_ID env fallback (fastly#1866) Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
…VICE_ID env fallback (fastly#1866) Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
jedisct1
force-pushed
the
fix-service-version-validate-service-id-fallback-1866
branch
from
September 21, 2026 10:50
d98c601 to
e893067
Compare
Contributor
|
LGTM, thank you! |
jedisct1
approved these changes
Sep 21, 2026
jedisct1
enabled auto-merge (squash)
September 21, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Fixes #1866
Allow \astly service version validate\ to fall back to the \FASTLY_SERVICE_ID\ environment variable when the --service-id\ flag is omitted or when running in non-interactive/automation environments.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Users executing \astly service version validate\ can rely on \FASTLY_SERVICE_ID\ without needing to pass --service-id\ explicitly on each execution.
Are there any considerations that need to be addressed for release?
None.