feat: handle user permissions - #31
Closed
jean-michelet wants to merge 11 commits into
Closed
Conversation
jean-michelet
force-pushed
the
authorization
branch
from
September 21, 2024 16:15
729cd2a to
6087f51
Compare
Signed-off-by: Jean <110341611+jean-michelet@users.noreply.github.com>
Member
Author
|
Any chance I have a review today? |
Member
|
I'll take a look |
gurgunday
reviewed
Sep 28, 2024
Member
Author
|
I think I am gonna close this PR and create a v0 PR wich tackle most of the issues needed for a complete api demo. |
Member
|
I assumed it wasn't ready when I saw that the CI was red, bad habit 😂 So it's ready to be reviewed? |
Member
Author
|
No, I didn't expect you to review (don't understand why the CI crash). |
Member
Author
|
@gurgunday |
Member
Author
|
Closed for #33 |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #29
I don't know if there's a popular way to manage role-based authorizations with Fastify.
So I made a simple custom implementation.