-
Notifications
You must be signed in to change notification settings - Fork 1
V143 json #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
V143 json #10
Changes from all commits
ea4087e
5aee755
ceed2ce
f1a8bf1
13562aa
32910e7
c5b6ac0
7ac11eb
7f9f283
8144dc7
6320ae3
e4632c0
698ff86
467b890
5a0cc82
8bd8cc4
974ffcd
39b8d14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,19 +20,28 @@ RUN cd /workspace \ | |
| && echo "$MAXWELL_VERSION" > /REVISION | ||
|
|
||
| # Build clean image with non-root priveledge | ||
| FROM openjdk:23-jdk-slim | ||
| FROM eclipse-temurin:23-jre-noble | ||
|
|
||
| RUN apt-get update \ | ||
| && apt-get -y upgrade | ||
|
|
||
| COPY --from=builder /app /app | ||
| COPY --from=builder /REVISION /REVISION | ||
| # COPY --from=builder /REVISION /REVISION | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| RUN useradd -u 1000 maxwell -d /app | ||
| RUN chown 1000:1000 /app | ||
| RUN echo "$MAXWELL_VERSION" > /REVISION | ||
| #USER 1000 | ||
|
|
||
| USER 1000 | ||
|
|
||
| RUN apt-get update && apt-get install -y --no-install-recommends wget unzip procps python3-pip htop | ||
| # RUN pipx install magic-wormhole | ||
|
|
||
| ARG ASYNC_PROFILER_VERSION=2.9 | ||
| RUN wget https://github.com/jvm-profiling-tools/async-profiler/releases/download/v${ASYNC_PROFILER_VERSION}/async-profiler-${ASYNC_PROFILER_VERSION}-linux-x64.tar.gz -O /tmp/async-profiler.tar.gz \ | ||
| && tar -xzf /tmp/async-profiler.tar.gz -C /opt \ | ||
| && rm /tmp/async-profiler.tar.gz | ||
| ENV ASYNC_PROFILER_HOME=/opt/async-profiler-${ASYNC_PROFILER_VERSION}-linux-x64 | ||
| ENV PATH="$PATH:${ASYNC_PROFILER_HOME}" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dockerfile runs as root with debug tools installedMedium Severity The non-root Reviewed by Cursor Bugbot for commit 5a0cc82. Configure here. |
||
|
|
||
| CMD [ "/bin/bash", "-c", "bin/maxwell-docker" ] | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile writes empty REVISION in second stage
Low Severity
RUN echo "$MAXWELL_VERSION" > /REVISIONruns in the second build stage whereMAXWELL_VERSIONis not defined (it's anENVonly in thebuilderstage). This writes an empty string to/REVISION, whereas the originalCOPY --from=builder /REVISION /REVISIONcorrectly propagated the version.Reviewed by Cursor Bugbot for commit 5a0cc82. Configure here.