Conversation
Member
|
Thanks for your interest and efforts! We ask people to only open PRs when it's explicitly requested by maintainers.
I will close this for now to keep things clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value this change must deliver
This template is the starting point for many production applications, but its docs currently say nothing about application-layer request protections:
backend/app/main.pyships only CORS middleware, with no rate limiting, payload inspection, or bot/probe filtering. This PR adds a docs-only "Production Hardening" section to the README stating what the template does not include, listing established options with their tradeoffs, and showing one compact wiring example built around a log-first rollout. Zero code paths are touched. It implements the docs-first option discussed in #2486; the placement is trivially movable if maintainers prefer another file.Disclosure: I maintain fastapi-guard, one of the options listed in the new section; the section itself is neutral and lists alternatives with tradeoffs.
What this changes
README.md— new## Production Hardeningsection (30 lines) between## Deploymentand## Development:fastapi-guardintobackend/app/main.pyin passive mode — start log-only, flippassive_mode=Falseto enforce.What this deliberately does not change
backend/,frontend/, or compose file changes.How to test
git diff origin/master --statshows exactly one file changed: