Repository navigation
test(base32): cover bulk scalar error offsets - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base32 bulk scalar decoding is bypassed by normal dispatch on SIMD hosts, and existing malformed-input fixtures are below its threshold. Add one direct test for global invalid-byte offsets and non-canonical tail errors after a bulk prefix.
Add 159-, 160-, and 164-byte caller-buffer benchmarks around the scalar threshold.
Validation:
cargo x test(625 test executions) andcargo x lintpass onaarch64-apple-darwinwith rustc 1.98.0.