fix: keep website utilities above docs theme css#339
Merged
Conversation
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/docslayout while fixing homepage/cloud utility overrides introduced by the unified theme CSS importVerification
git diff --checkcorepack pnpm format:checkcorepack pnpm lint(passes with existing warnings only)corepack pnpm --dir website exec next build/,/cloud, and/docsin local dev server, including dark-mode checks for/and/cloudNote: the full
website buildscript was not run because its nested plainpnpmcall resolves to global pnpm 11 locally and prompted to remove/reinstall workspace module directories; I declined that mutation and ran the narrower Next build throughcorepackinstead.Summary by cubic
Load the docs theme CSS before Tailwind so website utilities win on non-doc pages. This prevents docs theme overrides on
/and/cloudwhile keeping the full docs theme on/docs.Written for commit 15e1921. Summary will update on new commits.