fix: align threadline framework codeblock titles#338
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
@farming-labs/astro
@farming-labs/astro-theme
@farming-labs/docs
@farming-labs/theme
@farming-labs/next
@farming-labs/nuxt
@farming-labs/nuxt-theme
@farming-labs/svelte
@farming-labs/svelte-theme
@farming-labs/tanstack-start
commit: |
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/fumadocs/styles/threadline.css">
<violation number="1" location="packages/fumadocs/styles/threadline.css:1402">
P2: This footer override is gated on a `data-fd-framework` attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| display: none !important; | ||
| } | ||
|
|
||
| #nd-docs-layout[data-fd-framework] .fd-page-footer { |
There was a problem hiding this comment.
P2: This footer override is gated on a data-fd-framework attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/fumadocs/styles/threadline.css, line 1402:
<comment>This footer override is gated on a `data-fd-framework` attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).</comment>
<file context>
@@ -1399,6 +1399,12 @@ figure.shiki button[aria-label*="Copy"]:hover {
display: none !important;
}
+#nd-docs-layout[data-fd-framework] .fd-page-footer {
+ display: block !important;
+ margin-top: auto !important;
</file context>
Summary
Verification
Summary by cubic
Aligns threadline codeblocks, MDX surfaces, and page navigation with Next.js behavior. Unifies headers, typography, and layout across frameworks; examples now use
@farming-labs/theme/threadline.shiki/pre; matched font size/line-height; striped title bar with tuned dark-mode opacity.previousPage/nextPageprops; localizes URLs per active locale; hidden on changelog routes.Written for commit 31b85a1. Summary will update on new commits.