Skip to content

fix: align threadline framework codeblock titles#338

Merged
Kinfe123 merged 4 commits into
mainfrom
refactor/threadline-codeblock-title-parity
Jul 10, 2026
Merged

fix: align threadline framework codeblock titles#338
Kinfe123 merged 4 commits into
mainfrom
refactor/threadline-codeblock-title-parity

Conversation

@Kinfe123

@Kinfe123 Kinfe123 commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Align framework-rendered threadline titled codeblocks with the Next.js threadline shape
  • Remove the separate title border/slab, add the same striped title treatment, and match header/body sizing
  • Keep copy actions hidden at rest and revealed on hover/focus like Next.js

Verification

  • corepack pnpm --filter @farming-labs/theme run build
  • corepack pnpm --filter @farming-labs/theme run typecheck
  • corepack pnpm format:check
  • corepack pnpm lint (warnings only)
  • git diff --check
  • Playwright visual/geometry checks for Next.js and SvelteKit threadline titled codeblocks in light and dark modes

Summary by cubic

Aligns threadline codeblocks, MDX surfaces, and page navigation with Next.js behavior. Unifies headers, typography, and layout across frameworks; examples now use @farming-labs/theme/threadline.

  • Bug Fixes
    • Codeblocks (titled and plain): rounded container with shared background; transparent shiki/pre; matched font size/line-height; striped title bar with tuned dark-mode opacity.
    • Copy actions: hidden at rest and shown on hover/focus; consistent sizing and placement.
    • Framework page layout: unified grid widths and centered frame; fixed sidebar offsets; sticky TOC at xl+.
    • MDX surfaces: callouts use a slim indicator, inline titles, and adjusted text; tabs/code groups get compact headers and rounded corners; tables and TOC links use readable sizes and muted-to-active color states.
    • Page navigation: adds Previous/Next cards for framework docs; supports previousPage/nextPage props; localizes URLs per active locale; hidden on changelog routes.

Written for commit 31b85a1. Summary will update on new commits.

Review in cubic

@Kinfe123 Kinfe123 added the refactor: theme css Refactor theme CSS exports and framework styling label Jul 10, 2026
@vercel

vercel Bot commented Jul 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs-website Ready Ready Preview, Comment Jul 10, 2026 8:07pm
farming-labs-docs-docs-cloud Building Building Preview, Comment Jul 10, 2026 8:07pm

Request Review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@farming-labs/astro

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro@338

@farming-labs/astro-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/astro-theme@338

@farming-labs/docs

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/docs@338

@farming-labs/theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/theme@338

@farming-labs/next

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/next@338

@farming-labs/nuxt

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt@338

@farming-labs/nuxt-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/nuxt-theme@338

@farming-labs/svelte

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte@338

@farming-labs/svelte-theme

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/svelte-theme@338

@farming-labs/tanstack-start

pnpm add https://pkg.pr.new/farming-labs/docs/@farming-labs/tanstack-start@338

commit: 31b85a1

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/fumadocs/styles/threadline.css">

<violation number="1" location="packages/fumadocs/styles/threadline.css:1402">
P2: This footer override is gated on a `data-fd-framework` attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).</violation>
</file>

Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic

display: none !important;
}

#nd-docs-layout[data-fd-framework] .fd-page-footer {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This footer override is gated on a data-fd-framework attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/fumadocs/styles/threadline.css, line 1402:

<comment>This footer override is gated on a `data-fd-framework` attribute that the Tanstack Start/Fumadocs code in this batch does not emit, so the footer stays hidden on the newly wired pages. If the intent is to surface the framework footer here, the selector needs to match the actual layout root (or the root needs to set the attribute).</comment>

<file context>
@@ -1399,6 +1399,12 @@ figure.shiki button[aria-label*="Copy"]:hover {
   display: none !important;
 }
 
+#nd-docs-layout[data-fd-framework] .fd-page-footer {
+  display: block !important;
+  margin-top: auto !important;
</file context>

@vercel vercel Bot temporarily deployed to Preview – farming-labs-docs-docs-cloud July 10, 2026 20:04 Inactive
@Kinfe123 Kinfe123 merged commit cc83499 into main Jul 10, 2026
9 of 10 checks passed
@Kinfe123 Kinfe123 deleted the refactor/threadline-codeblock-title-parity branch July 10, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor: theme css Refactor theme CSS exports and framework styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant