ci: install .NET 6 in publish workflow#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
publish.yamlfailed on the 2.4.0 merge:tools/CaroKann(type generator) targets net6.0, butubuntu-latest(now ubuntu-24.04) no longer ships the .NET 6 runtime — only 8/9/10. Thepnpm build→build:typesstep aborts withMicrosoft.NETCore.App 6.0.0 not found, so Publish/tag never run. This blocks any release, not just 2.4.0.Fix
Add
actions/setup-dotnet@v4(6.0.x) after checkout so CaroKann's runtime is present. Type generation is unchanged.Effect
Merging this re-triggers
publish.yaml; with .NET 6 available the build proceeds and 2.4.0 publishes (npm currently at 2.3.0).Note: longer-term, retargeting CaroKann to net8 would drop the EOL-6 dependency, but that's a separate, riskier change.