Restructure experiment client #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passed to conditions
DELETED_AT_FILTER_BODY
Co-Authored-By: Andrew Crozier <wacrozier@gmail.com>
utilise marshmallow serialize methods for SingleFilterValueField serialisation
* Use marshmallow's `field.fail()` mechanism * Map fitler types to field types with dict * Factor out param filter type polymorphism
…ntation to context in which it is used
These methods were unused, untested, and in some cases broken.
…to restructure-experiment-client
haileyfong
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experiment module has been large and unwieldy - this PR breaks the implementation into several submodules.
This should be merged after PR #107.