fix(auth): a password reset for a passwordless account sends an email sign-in; one answer for every address - #48
Merged
Conversation
… sign-in; one answer for every address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch release for
@factiii/auth.sendPasswordResetEmail: an active account with an email and no password, requested with a knownappthat has email sign-in on, now gets the same link-and-code sign-in email asauth.emailLogin.requestinstead of an error. Password accounts get the reset link as before.{ message: 'If an account exists with that email, we sent a link.' }— padded to the email-login response floor, so the reply no longer reveals whether an account exists or how it signs in.Unknown app.is still a 400 for an unknown key.issueEmailLoginAttempt(same rate limits, single open attempt, hashed storage); send failures are logged, never thrown.Tests: 285/285 (5 new). check-types, lint, build clean.
changeset status: patch for@factiii/authonly.🤖 Generated with Claude Code
https://claude.ai/code/session_01H7frtoCH37E4RjrPC6zLPc