fix(auth): case-insensitive lookups no longer treat _ and % as wildcards - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix — patch release of @factiii/auth
Case-insensitive email and username lookups in the Prisma adapter now match exactly. On Postgres, Prisma's
mode: 'insensitive'equalscompiles toILIKE, so_and%in the value acted as pattern characters and a lookup could return a different account.utilities/emailMatch.ts:escapeLikePattern(escapes\,%,_) andsameIdentifier(case-insensitive exact compare; null never matches).adapters/prismaAdapter.ts: the three insensitive lookups send the escaped value and re-check the returned row.resolveLoginMethodsre-check the lookup result.lower(col) = lower($1)).Verified on a real Postgres database: an escaped look-alike no longer matches, and an exact address in different case still does.
Tests: 224/224 (10 new in
tests/insensitiveLookup.test.ts).changeset status: patch for@factiii/authonly.🤖 Generated with Claude Code
https://claude.ai/code/session_01H7frtoCH37E4RjrPC6zLPc