VRS cmake: fix fbsource build for rapidjson and Ocean (#249)#249
Closed
georges-berenger wants to merge 1 commit into
Closed
VRS cmake: fix fbsource build for rapidjson and Ocean (#249)#249georges-berenger wants to merge 1 commit into
georges-berenger wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@georges-berenger has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108821160. |
meta-codesync
Bot
changed the title
georges-berenger
added a commit
to georges-berenger/vrs-1
that referenced
this pull request
Jun 17, 2026
…ch#249) Summary: Fix the VRS cmake build system to work in fbsource, while preserving OSS build compatibility. - FindRapidjsonLib.cmake: Add fbsource third-party search path (${VRS_SOURCE_DIR}/../../../third-party/rapidjson/include) with NO_DEFAULT_PATH to avoid picking up old system rapidjson v1.1.0. Falls back to git clone for OSS builds. Remove bogus add_dependencies(rapidjson::rapidjson rapidjson) referencing non-existent target. - FindOcean.cmake: Add fbsource xplat/ocean search path, build via add_subdirectory if found. Falls back to FetchContent from github for OSS builds. This allows `cmake -S arvr/libraries/vrs -B build -G Ninja` to succeed in fbsource without internet access, using in-tree rapidjson and Ocean. Other dependencies (fmt, lz4, zstd, xxhash, etc.) are found via homebrew/system paths. Differential Revision: D108821160
georges-berenger
force-pushed
the
export-D108821160
branch
from
cbb2bed to
44df0ab
Compare
georges-berenger
added a commit
to georges-berenger/vrs-1
that referenced
this pull request
Jun 17, 2026
…ch#249) Summary: Fix the VRS cmake build system to work in fbsource, while preserving OSS build compatibility. - FindRapidjsonLib.cmake: Add fbsource third-party search path (${VRS_SOURCE_DIR}/../../../third-party/rapidjson/include) with NO_DEFAULT_PATH to avoid picking up old system rapidjson v1.1.0. Falls back to git clone for OSS builds. Remove bogus add_dependencies(rapidjson::rapidjson rapidjson) referencing non-existent target. - FindOcean.cmake: Add fbsource xplat/ocean search path, build via add_subdirectory if found. Falls back to FetchContent from github for OSS builds. This allows `cmake -S arvr/libraries/vrs -B build -G Ninja` to succeed in fbsource without internet access, using in-tree rapidjson and Ocean. Other dependencies (fmt, lz4, zstd, xxhash, etc.) are found via homebrew/system paths. Differential Revision: D108821160
georges-berenger
force-pushed
the
export-D108821160
branch
from
44df0ab to
c8da148
Compare
…ch#249) Summary: Fix the VRS cmake build system to work in fbsource, while preserving OSS build compatibility. - FindRapidjsonLib.cmake: Add fbsource third-party search path (${VRS_SOURCE_DIR}/../../../third-party/rapidjson/include) with NO_DEFAULT_PATH to avoid picking up old system rapidjson v1.1.0. Falls back to git clone for OSS builds. Remove bogus add_dependencies(rapidjson::rapidjson rapidjson) referencing non-existent target. - FindOcean.cmake: Add fbsource xplat/ocean search path, build via add_subdirectory if found. Falls back to FetchContent from github for OSS builds. This allows `cmake -S arvr/libraries/vrs -B build -G Ninja` to succeed in fbsource without internet access, using in-tree rapidjson and Ocean. Other dependencies (fmt, lz4, zstd, xxhash, etc.) are found via homebrew/system paths. Differential Revision: D108821160
georges-berenger
force-pushed
the
export-D108821160
branch
from
c8da148 to
9f34bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the VRS cmake build system to work in fbsource, while preserving OSS build compatibility.
FindRapidjsonLib.cmake: Add fbsource third-party search path (${VRS_SOURCE_DIR}/../../../third-party/rapidjson/include) with NO_DEFAULT_PATH to avoid picking up old system rapidjson v1.1.0. Falls back to git clone for OSS builds. Remove bogus add_dependencies(rapidjson::rapidjson rapidjson) referencing non-existent target.
FindOcean.cmake: Add fbsource xplat/ocean search path, build via add_subdirectory if found. Falls back to FetchContent from github for OSS builds.
This allows
cmake -S arvr/libraries/vrs -B build -G Ninjato succeed in fbsource without internet access, using in-tree rapidjson and Ocean. Other dependencies (fmt, lz4, zstd, xxhash, etc.) are found via homebrew/system paths.Differential Revision: D108821160