This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Remove explicit include for gtest for old CMake#63
Open
JoeLoser wants to merge 1 commit into
Open
Conversation
Summary: - For older versions of CMake -- specifically 2.8.11 or lower, you need to explicitly add the incldue directory for gtest. - However, since `pushmi` requires CMake 3.7 or later, this does not need to be guarded against.
facebook-github-bot
added
the
CLA Signed
Author
|
@ericniebler looks like Travis needs some love to make the build matrix green again, unrelated to this changeset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
to explicitly add the incldue directory for gtest.
pushmirequires CMake 3.7 or later, this does notneed to be guarded against.