Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Increase required CMake version to 3.8#25

Open
brycelelbach wants to merge 1 commit into
facebookresearch:masterfrom
brycelelbach:missing_cmake_version_requirement
Open

Increase required CMake version to 3.8#25
brycelelbach wants to merge 1 commit into
facebookresearch:masterfrom
brycelelbach:missing_cmake_version_requirement

Conversation

@brycelelbach

Copy link
Copy Markdown

pushmi uses the CMake cxx_std_XX compile features, which were introduced in CMake 3.7. However, pushmi currently only requires CMake version 3.7. So, if you happen to be using CMake version 3.7, running CMake fails with a cryptic error:

$ cmake --version
cmake version 3.7.2

CMake suite maintained and supported by Kitware (kitware.com/cmake).

$ /home/wash/install/nvidia/cuda-9.2.88/bin/nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2018 NVIDIA Corporation
Built on Wed_Apr_11_23:16:29_CDT_2018
Cuda compilation tools, release 9.2, V9.2.88

$ g++ --version
g++ (Debian 6.4.0-12) 6.4.0 20180123
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ git rev-parse HEAD
cedca49cdc60413c35f64710eb5ea3987111b380

$ ls
buildSingleHeader.cmake  CMakeLists.txt  CODE_OF_CONDUCT.md  CONTRIBUTING.md  examples  external  include  ISSUES  LICENSE  Readme.md  TARGETS  test

$ mkdir build

$ cd build

$ cmake -DCMAKE_CXX_COMPILER=/home/wash/install/nvidia/cuda-9.2.88/bin/nvcc ..
-- The CXX compiler identification is GNU 6.4.0
-- Check for working CXX compiler: /home/wash/install/nvidia/cuda-9.2.88/bin/nvcc
-- Check for working CXX compiler: /home/wash/install/nvidia/cuda-9.2.88/bin/nvcc -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - failed
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE  
-- Configuring done
CMake Error in examples/twoway_execute/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "twoway_execute_2".


CMake Error in examples/then_execute/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "then_execute_2".


CMake Error in examples/composition/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "composition_3".


CMake Error in examples/composition/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "composition_2".


CMake Error in examples/composition/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "composition_4".


CMake Error in examples/for_each/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "for_each_3".


CMake Error in examples/for_each/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "for_each_2".


CMake Error in examples/reduce/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "reduce_3".


CMake Error in examples/reduce/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "reduce_2".


CMake Error in test/CMakeLists.txt:
  Specified unknown feature "cxx_std_14" for target "PushmiTest".


-- Generating done
-- Build files have been written to: /home/wash/development/iso-c++/pushmi/build

This PR increases the minimum CMake version to 3.8.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 27, 2021
@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants