This repository was archived by the owner on Jan 2, 2021. It is now read-only.
Enable missing-prototypes compiler warning#257
Open
strager wants to merge 1 commit intofacebookarchive:masterfrom
Open
Enable missing-prototypes compiler warning#257strager wants to merge 1 commit intofacebookarchive:masterfrom
strager wants to merge 1 commit intofacebookarchive:masterfrom
Conversation
Contributor
|
I'm fine with this, but it looks like it breaks the builds on travis. |
Enable Clang's and GCC's -Wmissing-prototypes diagnostic and fix issues it catches. This unconcovered some dead code, so delete the dead code.
strager
force-pushed
the
strager-missing-prototypes
branch
from
4b63624 to
c58a92a
Compare
Contributor
|
This needs only a small fix in cmake before landing. Are you interested in fixing it? |
sas
suggested changes
Jan 22, 2018
Contributor
sas
left a comment
sas
left a comment
There was a problem hiding this comment.
Seems fine overall except it breaks the builds.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Clang's and GCC's -Wmissing-prototypes diagnostic and
fix issues it catches. This unconcovered some dead code, so
delete the dead code.