Integrate app menu with DevTools features, add icons#56875
Open
huntie wants to merge 2 commits into
Open
Conversation
Summary: Upgrade from Electron 39.0.0 → 43.0.0-alpha.3. Changelog: [Internal] **Breaking changes from Electron 39.0.0 → 43.0.0-alpha.3:** **Electron 40.0.0** - Deprecated `clipboard` API access from renderer processes (use `contextBridge` from a preload script) - macOS dSYM debug symbols now compressed with `tar.xz` (`dsym.zip` → `dsym.tar.xz`) **Electron 41.0.0** - PDFs no longer create a separate `WebContents` (now render in same WebContents via OOPIFs — use frame tree to detect) - Cookie `'changed'` event has new causes: `inserted`, `inserted-no-change-overwrite`, `inserted-no-value-change-overwrite` - Deprecated `showHiddenFiles` in dialogs on Linux (GTK removed the API) **Electron 42.0.0** - macOS notifications migrated from `NSUserNotification` to `UNNotification` API (requires code-signed app, else emits `failed` event) - Offscreen rendering defaults to `1.0` device scale factor (use `webPreferences.offscreen.deviceScaleFactor` to override) - `electron` npm package no longer downloads via `postinstall` (binary fetched on first `bin` run; `ELECTRON_SKIP_BINARY_DOWNLOAD` removed, use `ELECTRON_INSTALL_PLATFORM` / `ELECTRON_INSTALL_ARCH`) - Removed `quotas` object from `Session.clearStorageData(options)` **Electron 43.0.0-alpha.3** - No breaking changes documented yet (Chromium bumped to 150.0.7834.0) Command run: ``` js1 upgrade electron --version 43.0.0-alpha.3 ``` Differential Revision: D105587351
Summary:
UX polish: Refine RNDT desktop app with new menu items mapping to key features inside the DevTools UI, and adding menu item icons (macOS 26+).
**New/changed menu items**
- **[New] File > Reload App** - Unify cmd+R logic — explicitly bound to "Reload App".
- **[New] File > Reload DevTools** - opt+R — reinstates above
- Note: Reloading and force-reloading the debugger-frontend's UI can also be done with cmd+R and cmd+shift+R *from a DevTools-on-DevTools window*.
- **[New] File > QuickOpen…** -
- **[New] View > Command Palette…** -
- **[Changed] View > Toggle Developer Tools** - Shown in debug builds only. Delete Reload and Force Reload items here (per above).
- Simplify Edit menu options.
**Notes**
- Icons are configured on macOS 26+ only, and we've left the `{role: '<name>'}` icon templates alone (should be managed upstream in Electron, although today these icons are missing in some cases).
See electron/electron#50609, electron/electron#48909.
Changelog:
[General][Added] - **React Native DevTools**: Expose new options in the app menu
Differential Revision: D94527813
meta-cla
Bot
added
the
CLA Signed
huntie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
UX polish: Refine RNDT desktop app with new menu items mapping to key features inside the DevTools UI, and adding menu item icons (macOS 26+).
New/changed menu items
Notes
{role: '<name>'}icon templates alone (should be managed upstream in Electron, although today these icons are missing in some cases).See electron/electron#50609, electron/electron#48909.
Changelog:
[General][Added] - React Native DevTools: Expose new options in the app menu
Differential Revision: D94527813