fix LiteralString inference on dict keys #2517#4211
Open
asukaminato0721 wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: rotki (https://github.com/rotki/rotki)
- ERROR rotkehlchen/api/services/assets.py:1031:38-77: No matching overload found for function `typing.MutableMapping.setdefault` called with arguments: (str, CounterpartyDetails) [no-matching-overload]
jinja (https://github.com/pallets/jinja)
- ERROR src/jinja2/lexer.py:182:10-34: No matching overload found for function `dict.get` called with arguments: (str, str) [no-matching-overload]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2517
changes dict key inference so inferred dict keys are widened to their natural runtime type (str for string-like keys, and similarly for other literals) instead of staying pinned to literal precision.
Test Plan
add test