fix Renaming Protocol renames __init__ method instead of class #4170#4202
Closed
asukaminato0721 wants to merge 1 commit into
Closed
fix Renaming Protocol renames __init__ method instead of class #4170#4202asukaminato0721 wants to merge 1 commit into
asukaminato0721 wants to merge 1 commit into
Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
@stroxler has imported this pull request. If you are a Meta employee, you can view this in D112881319. |
stroxler
approved these changes
Jul 20, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, I'll try to get it merged soon
yangdanny97
approved these changes
Jul 20, 2026
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4170
Rename now resolves constructor calls to the class symbol, while find-references still follows
__init__/__new__as intended.prepareRename uses the same raw-symbol behavior.
Test Plan
add test