feat(suppress): support removal of # type: ignore suppressions with pyrefly suppress --remove-unused#4200
Open
tobyh-canva wants to merge 5 commits into
Open
Conversation
tobyh-canva
commented
Jul 18, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tobyh-canva
marked this pull request as ready for review
July 18, 2026 08:45
This comment has been minimized.
This comment has been minimized.
Contributor
|
@kinto0 has imported this pull request. If you are a Meta employee, you can view this in D113126957. |
kinto0
approved these changes
Jul 21, 2026
kinto0
left a comment
Contributor
There was a problem hiding this comment.
would love @maggiemoss 's perspective on this
kinto0
reviewed
Jul 21, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
|
What if instead of new flags for each kind of ignore, we had the ability to pass an option to it and specify which kind? |
maggiemoss
requested changes
Jul 22, 2026
Collaborator
Author
|
Here's what the flag's help looks like from |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
--remove-unused-type-ignores flag# type: ignore suppressions with pyrefly suppress --remove-unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
pyrefly suppress --remove-unusedandpyrefly check --remove-unused-ignoresso that users can specify--remove-unused=type/--remove-unused=allto instead / additionally remove# type: ignorecomments, rather than just# pyrefly: ignorecomments.The default remains unchanged, so as to not surprise users previously relying on
pyrefly suppress --remove-unusedsuddenly removing load-bearing# type: ignorecomments.Resolves #3984.