HEAD request and Content-Lenght

[rafalwijata]

Hi, I encountered this funny issue while using proxygen as server.
On HEAD request I'm suppose to set Content-Lenght to value it would be and send no body.
So I do,
...
builder->header(proxygen::HTTP_HEADER_CONTENT_LENGTH, std::to_string(len));
builder->sendWithEOM();
however the latter sendWithEOM() (calls send()) resets the Content-Lenght back to zero.
I workarounded that by sending empty chunk first before sendWithEOM().

But I wonder if this is proxygen ResponseBuilder issue or I'm doing it wrong?

[hanidamlaj]

Thanks for the issue! Yep, this sounds like a small issue with ResponseBuilder – we shouldn't reset the "content-length" header field value for HEAD responses

[dennisimoo]

I can reproduce the cause in the current ResponseBuilder: sendWithEOM() adds Content-Length: 0 even when a bodyless response already has an explicit length. I see this is assigned to @hanidamlaj; I am preparing a small regression test and patch for review, preserving the existing automatic length calculation when no length was supplied.