Skip to content

bump agp to 9.2.1 and ndk to r28c - #2866

Closed
Kudo wants to merge 1 commit into
facebook:mainfrom
Kudo:@kudo/ndkr28
Closed

Kudo wants to merge 1 commit into
facebook:mainfrom
Kudo:@kudo/ndkr28

Conversation

@Kudo

@Kudo Kudo commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the main branch

Motivation (required)

for react-native ndk r28c bump react/react-native#58650. we should also align the dependencies for the libraries

Changes

  • bump agp to 9.2.1
  • ./gradlew wrapper --gradle-version 9.4.1 --distribution-type bin because agp 9 requires newer gradle wrapper
  • bump ndk to r28c
  • remove apply plugin: 'kotlin-android' because agp 9 has builtin kotlin support
  • kapt to legacy-kapt
  • some dependencies updates because of android.dependency.useConstraints is false since agp 9

Test Plan (required)

test aar build passed and verify the *.so is built by ndk r28c

Next Steps

Sign the CLA, if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all tests pass on Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the Contributing guide.

@meta-codesync

meta-codesync Bot commented Sep 25, 2026

Copy link
Copy Markdown

@cortinico has imported this pull request. If you are a Meta employee, you can view this in D121799286.

@meta-codesync meta-codesync Bot closed this in d74afa8 Sep 25, 2026
@meta-codesync meta-codesync Bot added the Merged label Sep 25, 2026
@meta-codesync

meta-codesync Bot commented Sep 25, 2026

Copy link
Copy Markdown

@cortinico merged this pull request in d74afa8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant