Conversation
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D121799286. |
|
@cortinico merged this pull request in d74afa8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please read these instructions carefully:
mainbranchMotivation (required)
for react-native ndk r28c bump react/react-native#58650. we should also align the dependencies for the libraries
Changes
./gradlew wrapper --gradle-version 9.4.1 --distribution-type binbecause agp 9 requires newer gradle wrapperapply plugin: 'kotlin-android'because agp 9 has builtin kotlin supportandroid.dependency.useConstraintsis false since agp 9Test Plan (required)
test aar build passed and verify the *.so is built by ndk r28c
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the Contributing guide.