Skip to content

Make curve25519-dalek and ed25519-dalek required in akd_core #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootkiller6788 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

Make curve25519-dalek and ed25519-dalek required in akd_core #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions akd_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@ nostd = []
# Supported configurations
whatsapp_v1 = ["dep:blake3"]
experimental = ["dep:blake3"]
# Include the VRF verification logic
vrf = ["ed25519-dalek", "curve25519-dalek"]
# (Deprecated) The VRF verification logic is always compiled in, so this
# feature no longer gates anything. Kept as an empty feature for backwards
# compatibility with crates that enable `akd_core/vrf`.
vrf = []
serde_serialization = ["dep:serde", "dep:serde_bytes", "ed25519-dalek/serde"]
# Parallelize VRF calculations during publish
parallel_vrf = ["tokio"]
Expand All @@ -37,11 +39,11 @@ default = ["vrf", "experimental"]
[dependencies]
## Required dependencies ##
async-trait = "0.1"
curve25519-dalek = { version = "4", optional = true }
curve25519-dalek = { version = "4" }
ed25519-dalek = { version = "2", features = [
"digest",
"legacy_compatibility",
], optional = true }
] }
hex = "0.4"
zeroize = "1"

Expand Down
3 changes: 0 additions & 3 deletions akd_core/src/verify/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ pub enum VerificationError {
/// Error verifying a history proof
HistoryProof(String),
/// Error verifying a VRF proof
#[cfg(feature = "vrf")]
Vrf(crate::ecvrf::VrfError),
/// Error converting protobuf types during verification
#[cfg(feature = "protobuf")]
Expand All @@ -46,7 +45,6 @@ impl core::fmt::Display for VerificationError {
}
VerificationError::LookupProof(err) => format!("(Lookup proof) - {err}"),
VerificationError::HistoryProof(err) => format!("(History proof) - {err}"),
#[cfg(feature = "vrf")]
VerificationError::Vrf(vrf) => vrf.to_string(),
#[cfg(feature = "protobuf")]
VerificationError::Serialization(proto) => proto.to_string(),
Expand All @@ -55,7 +53,6 @@ impl core::fmt::Display for VerificationError {
}
}

#[cfg(feature = "vrf")]
impl From<crate::ecvrf::VrfError> for VerificationError {
fn from(input: crate::ecvrf::VrfError) -> Self {
VerificationError::Vrf(input)
Expand Down