Skip to content

Enhance PathPicker: Regex/File Parsing & Command Mode#440

Open
rahmaaismail wants to merge 1 commit intofacebook:mainfrom
rahmaaismail:feature/parse-command-mode
Open

Enhance PathPicker: Regex/File Parsing & Command Mode#440
rahmaaismail wants to merge 1 commit intofacebook:mainfrom
rahmaaismail:feature/parse-command-mode

Conversation

@rahmaaismail
Copy link

Regex/File Parsing Improvements:

  • Improved file detection with advanced regex patterns
  • Added support for complex filenames, unicode paths, and deleted git files
  • Optimized performance for large file lists

Command Mode Enhancements:

  • Added command_mode.py with:
    • expand_tokens for custom token replacement (, , )
    • run_command for safe execution of shell commands with optional confirmation
  • Updated screen.py:
    • handle_command_mode for command input
    • clrtoeol to clear input lines
    • Integrated command execution with token expansion
    • Updated input loop to support ':' for command mode

Regex/File Parsing Improvements:
- Improved file detection with advanced regex patterns
- Added support for complex filenames, unicode paths, and deleted git files
- Optimized performance for large file lists

Command Mode Enhancements:
- Added command_mode.py with:
  - expand_tokens for custom token replacement (, , )
  - run_command for safe execution of shell commands with optional confirmation
- Updated screen.py:
  - handle_command_mode for command input
  - clrtoeol to clear input lines
  - Integrated command execution with token expansion
  - Updated input loop to support ':' for command mode
@meta-cla
Copy link

meta-cla bot commented Mar 8, 2026

Hi @rahmaaismail!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Mar 8, 2026
@meta-cla
Copy link

meta-cla bot commented Mar 8, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant