Skip to content

fix: allow ts_active_atoms to accept list[int] directly (closes #233)#252

Open
botbikamordehai2-sketch wants to merge 1 commit into
faccts:mainfrom
botbikamordehai2-sketch:fix/issue-233-1781350048
Open

fix: allow ts_active_atoms to accept list[int] directly (closes #233)#252
botbikamordehai2-sketch wants to merge 1 commit into
faccts:mainfrom
botbikamordehai2-sketch:fix/issue-233-1781350048

Conversation

@botbikamordehai2-sketch

Copy link
Copy Markdown

What

The ts_active_atoms field in BlockGeom was typed as Hybrid, which requires a mode string and cannot be instantiated with a plain list. According to ORCA documentation, ts_active_atoms expects a simple list of integers, not a wrapped Hybrid object.

Fix

Changed the type of ts_active_atoms from Hybrid to Optional[list[int]] (with appropriate pydantic validation to ensure positive integers). Removed the Hybrid dependency for this field, allowing users to pass [1, 2, 3] directly.

Closes #233

@botbikamordehai2-sketch botbikamordehai2-sketch requested a review from a team as a code owner June 13, 2026 11:27
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS Active Atoms Invalid Input

2 participants