fix: correct type annotation of ts_active_atoms and ts_active_atoms2 in BlockGeom#249
Open
nakul680 wants to merge 2 commits into
Open
fix: correct type annotation of ts_active_atoms and ts_active_atoms2 in BlockGeom#249nakul680 wants to merge 2 commits into
ts_active_atoms and ts_active_atoms2 in BlockGeom#249nakul680 wants to merge 2 commits into
Conversation
…s2` in `BlockGeom`.
timmyte
approved these changes
Jun 10, 2026
timmyte
left a comment
timmyte
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this issue. Please consider my two minor remarks before merging. Thanks!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issues
Closes #233
...
Description
ts_active_atomsandts_active_atoms2Release Notes
(Project adheres to Keep a Changelog; Every entry should start in upper-case and end with
(#<pr-id>); Remove sections that don't apply)Added
ts_active_atoms_init()to allow user to initializeIntGroupEndobject forts_active_atomsusing just a list.(TS Active Atoms Invalid Input #233)Fixed
ts_active_atomsandts_active_atoms2inBlockGeom(TS Active Atoms Invalid Input #233)