Skip to content

feat: implement frequency getters#247

Merged
haneug merged 5 commits into
faccts:mainfrom
haneug:feature/246-get-freq
Jun 2, 2026
Merged

feat: implement frequency getters#247
haneug merged 5 commits into
faccts:mainfrom
haneug:feature/246-get-freq

Conversation

@haneug

@haneug haneug commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Closes Issues

Closes #246

Description

  • Implements new getter functions that work with frequency calculations.
  • Includes get_frequencies, get_imaginary_frequencies, is_pes_minimum, and is_pes_transition_state.
  • Comes with a new example 56 that demonstrates how to use these in a transition state optimization.

Release Notes

Added

- Implements new getter functions that work with frequency calculations.
- Includes `get_frequencies`, `get_imaginary_frequencies`, `is_pes_minimum`, and `is_pes_transition_state`.
- Comes with a new example 56 that demonstrates how to use these in a transition state optimization.
@haneug haneug self-assigned this Jun 1, 2026
@haneug haneug requested a review from a team as a code owner June 1, 2026 13:04
@haneug haneug added the enhancement New feature or request label Jun 1, 2026
@haneug haneug requested a review from timmyte June 1, 2026 13:08
@haneug haneug added the side output Concerning parsing ORCA output label Jun 1, 2026

@timmyte timmyte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these getters.
Please consider adding the threshold parameter consistently to all the new methods.

Comment thread src/opi/output/core.py
Comment thread src/opi/output/core.py Outdated
Comment thread src/opi/output/core.py Outdated
Comment thread tests/examples/test_exmp056_optts_freq.py
@haneug haneug merged commit 6e06724 into faccts:main Jun 2, 2026
6 checks passed
@haneug haneug deleted the feature/246-get-freq branch June 2, 2026 12:30
haneug added a commit to haneug/opi that referenced this pull request Jun 2, 2026
## Closes Issues
Closes faccts#246

## Description
- Implements new getter functions that work with frequency calculations.
- Includes `get_frequencies`, `get_imaginary_frequencies`,
`is_pes_minimum`, and `is_pes_transition_state`.
- Comes with a new example 56 that demonstrates how to use these in a
transition state optimization.

---

## Release Notes

### Added 

- Added `get_frequencies`, `get_imaginary_frequencies`,
`is_pes_minimum`, and `is_pes_transition_state` to the `Output` class
(faccts#247).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request side output Concerning parsing ORCA output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add getter function for frequencies and imaginary frequencies.

2 participants