WIP: Additional integral getters#243
Conversation
|
Although the additional objects added here are sufficient to extract and parse the two electron integral information (at least from my testing), I have not yet gone ahead and added getters. Given there are so many possible two electron integrals I'm not sure if you wish to have separate getters as is currently done or go for a different approach, but I wanted to check before adding hundreds of lines of boilerplate. |
|
Thank you very much for your nice PR. The unit tests opi/tests/unit/test_output_attributes.py Line 46 in 821671e Or, if you would provide an example that makes use of the new pydantic fields and getters we could add it to the JSON fixtures and cover them in the attribute output tests. |
|
Thanks for the help! I've updated the integrals test example with the additional single electron getters and added the two electron integrals to the ignore list for now. Unit tests now seem to pass locally. |
haneug
left a comment
There was a problem hiding this comment.
Very Nice PR, I only found a small typo and have two suggestions for slightly different naming. I did not come to thoroughly check the two electron integrals but from what I see it looks good.
|
Nice, I would merge your PR. If you could also add your release note section to the |
|
Great, updated the changelog now! Just wanted check as well if you had any thoughts on the format for the two electron integral getters (which currently aren't included here). |
|
@vaferreiQMT Thanks for the additions to the changelog. There seems to be an issue with the license. That sometimes happens and in my experience an empty commit can resolve the issue sometimes. |
|
Thank you for contributing to OPI and making it better. Regarding the two electron integral getters I do not have a strong opinion and would just expose them as ORCA supplies them. If you require anything specific / any specific convention we would love to hear it! |
Closes Issues
Closes #240
Description
t_matrix,v_matrixandhmotoMoleculealong with corresponding getters insrc/opi/output/core.py(get_int_kinetic,get_int_nuclear,get_int_hmo)TwoElectronIntegralElementtype for the sparse COO 4 index matrix elementsMolecularTwoElectronIntegralclass for two electron integrals in MO basisTwoElectronIntegralsclass for all two electron integral information and correspondingtwoelintegralsinMoleculeclassI have attempted to reproduce the style and format of the existing code but of course a lot of it is also up to taste in terms of how things are arranged and named so very happy for you to change it as you see fit.
Release Notes
Added
t_matrix,v_matrix,hmo,twoelintegralsparameters toMoleculeclass (WIP: Additional integral getters #243)get_int_kinetic,get_int_nuclear,get_int_hmogetters for one electron integrals (WIP: Additional integral getters #243)TwoElectronIntegralElement,MolecularTwoElectronIntegralandTwoElectronIntegralsfor structuring two electron integral information (WIP: Additional integral getters #243)