Updated BaseRunner.run API#238
Open
MattBurn wants to merge 11 commits into
Open
Conversation
Contributor
Author
|
Apologies for the number of CI runs, finally figured out how nox works to check locally in the future |
Contributor
Anything that could be improved in the docs to make this clearer? |
Contributor
Author
|
I am new to nox so I did not grasp what nox was going to run in CI before pushing. I ended up using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issues
Closes #235
Description
capture,silent,stdout, andstderrcontrols inBaseRunner.runwith explicitstdout/stderrstream targets.Path, string paths, open text streams, callbacks,subprocess.PIPEcapture, and multiple destinations usingopi.execution.text_stream.TextStreamFanout.opi.execution.base.RunResultandopi.execution.run.SubprocessRunResultwith captured output, return-code helpers.stdin_str,capture, andsilentin favor ofstdinandstdout/stderrstream targets.Release Notes
Added
TextStreamFanoutstream-target fanout support for subprocess stdout and stderr destinations. (UpdatedBaseRunner.runAPI #238)BaseRunner.runAPI #238)Changed
BaseRunner.runto use explicit stdout and stderr stream targets. (UpdatedBaseRunner.runAPI #238)BaseRunner.runto return aRunResultinstead ofsubprocess.CompletedProcessorNone. (UpdatedBaseRunner.runAPI #238)Deprecated
stdin_str,capture, andsilentonBaseRunner.run. (UpdatedBaseRunner.runAPI #238)