Refactoring resource unpacking routines for better code readability#13
Open
felipesanches wants to merge 2 commits into
Open
Refactoring resource unpacking routines for better code readability#13felipesanches wants to merge 2 commits into
felipesanches wants to merge 2 commits into
Conversation
|
👍 |
Owner
There was a problem hiding this comment.
This change doesn't look right (line 57): wrong parameter called.
Owner
|
Because I have been able to test it. Some of changes look weird (like parameter used in the opposite way they used to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.