Repository navigation
refactor: split keep into the shared saas-service skeleton - #7
Merged
Merged
Conversation
Move keep to the aw S5 saas-service skeleton (one package per context): - keep-core -> keep-shared-kernel (value types, errors, cluster topology, metrics, TLS helpers). - keep-engine -> keep-keyspace (the KV engine with its engine-aware snapshot, recovery and persistence handle). - New keep-storage: the on-disk record format, WAL, blob store and persistence settings, moved out of keep-engine/src/persistence. It has no engine types, so keyspace -> storage has no cycle. - New keep-replication: raft.rs (feature "raft") and backup.rs. - New keep-access: http/auth.rs. - keep-http -> keep-commands (the HTTP/h2c + OpenAPI surface). The `keep` facade re-exports the old module paths (keep::engine, keep::persistence, keep::http, keep::raft, ...), so callers do not change. Also: - ddd.toml with the canonical policy, report only (enforce = false): engine.rs, bin/keep.rs and http/handlers.rs are over size_error. - aw.toml: kind = "saas-service"; an SV7 exception for the gke-test overlay, which lands in keep#6. - Workspace clippy lint mod_module_files = "deny". - build.rs uses core/build-stamp (core-reuse CR6). - keep-storage: fix the clippy findings the old crate-wide allow(clippy::all) hid (outer //! docs, WalHeader Default, a borrow). - README crate table.
This was referenced Oct 22, 2026
chrischeng-c4
added a commit
to faberline/aw
that referenced
this pull request
Oct 23, 2026
…itory (#65) The status table in docs/standards/saas-service.md names the S5 pull request for each saas-service repository: faberline/tape#29, faberline/defer#29, faberline/relay#57, faberline/lumen#159, #160 and #161, and faberline/keep#7. All of them merged on 2026-10-23. The one exception left is keep's SV7, until faberline/keep#6.
chrischeng-c4
added a commit
that referenced
this pull request
Oct 23, 2026
…a035 * commit '90e551c939bbbfdfe78a8f19ba4bf9947a63aaea': refactor: split keep into the shared saas-service skeleton (#7) # Conflicts: # Cargo.lock # crates/keep-commands/src/http.rs # crates/keep-http/src/lib.rs # crates/keep-keyspace/Cargo.toml # crates/keep-keyspace/src/lib.rs # crates/keep-replication/src/raft.rs # crates/keep/src/lib.rs
chrischeng-c4
added a commit
that referenced
this pull request
Oct 23, 2026
…etry * commit '90e551c939bbbfdfe78a8f19ba4bf9947a63aaea': refactor: split keep into the shared saas-service skeleton (#7) # Conflicts: # Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move keep to the shared saas-service skeleton (aw standard S5, faberline/aw#64). One package per context:
keepkeepkeepbinary, the facade library, integration tests, bencheskeep-shared-kernelkeep-corekeep-storagekeep-enginekeep-keyspacekeep-enginekeep-replicationkeep-engineraftper-shard hosts (featureraft), backup and restorekeep-accesskeep-httpservice-authkeep-commandskeep-httpkeep-operator,keep-clientkeep-shared-kernelThe storage split has no cycle:
keep-storageholds only the on-disk primitives. The engine-aware snapshot and recovery stay inkeep-keyspace.The
keepfacade re-exports the old paths (keep::engine,keep::persistence,keep::http,keep::raft, ...). Callers do not change.Also
ddd.tomlwith the canonical policy, report only (enforce = false).aw.toml:kind = "saas-service", and an SV7 exception fork8s/overlays/gke-test(it lands in feat(gke-test): test keep on the shared faberline GKE cluster #6).mod_module_files = "deny".build.rsusescore/build-stamp(core-reuse CR6).keep-storage: fixed 4 clippy findings that the old crate-wideallow(clippy::all)hid.Checks (local)
cargo fmt --all -- --checkcargo clippy --workspace --all-targets [--all-features] -- -D warningscargo test --workspaceand--all-featuresaw.scripts.saas_service check(S5)aw.scripts.standards check(core-reuse)aw standards rust-arch checkverify-release-contract.py --app keep,--self-test; receipt--self-testFollow-up (not in this PR)
rust-arch findings that keep had before this PR. The S5 move does not add them:
keep-keyspace/src/engine.rs(3493 lines),keep/src/bin/keep.rs(1674),keep-commands/src/http/handlers.rs(1135).bin/keep.rsholds the CLI, not onlyfn main.tests/it/.docs/README.md,architecture.md,glossary.md,domain/,adr/,operations/are missing.crc32fast,rust_decimal,rustls,utoipa.When these are fixed, set
enforce = true.Do not merge yet: the five S5 PRs merge together.
🤖 Generated with Claude Code