Repository navigation
ci: run fmt, clippy, tests, and the release contract on every pull request - #13
Merged
Merged
Conversation
…quest Keep had no pull_request workflow, so its PRs had no checks. The issue loop's review step merges a PR only after its checks pass, and it blocks the issue of a PR without checks. Add keep-ci on pull_request and on push to main: cargo fmt --check, clippy with -D warnings, the workspace tests, and verify-release-contract.py.
Stable Rust 1.99 deprecates AtomicUsize::fetch_update, and clippy -D warnings fails on it. The image builds with rust:1.92, so CI uses the same toolchain.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep has no
pull_requestworkflow, so a PR has no checks. The issue loop's review step (faberline/aw#67) reads the PR and its checks and runs no tests. It merges only after the checks pass, and it blocks the issue of a PR without checks.This adds
.github/workflows/keep-ci.yml, onpull_requestand onpushtomain:cargo fmt --all -- --checkcargo clippy --locked --workspace --all-targets --all-features -- -D warningscargo test --locked --workspacescripts/release/verify-release-contract.py --app keepThe job follows defer's
defer-ci.yml. The action pins and the uv setup are the same as inkeep-release-candidate.yml. The release contract checks only the release workflows, so a new workflow does not change it.GKE e2e stays in #6.
Checks
origin/main(680c296): all exit 0.keep-ciitself.After merge,
loop.sh labelsruns once in keep.🤖 Generated with Claude Code