Skip to content

Delivery prerequisite: finish existing GKE pilot PR #6 without duplicate implementation #17

Open

Description

@chrischeng-c4

Scope and evidence

Track and finish the existing PR #6, not a new pilot. Head 26754016398ec5ae4b35af68dd52d0414b029a1e has successful GKE jobs at https://github.com/faberline/keep/actions/runs/38774293655, but remains unmerged. Main has no GKE workflow; .github/issue-ci-required-gates.json explicitly blocks qualification on the missing merged current-head cloud functional/e2e gate and affected performance coverage. PR6 body mentions an obsolete AW branch, while its actual workflow uses AW@main.

Acceptance / execution order

  • Verify original owner, worktree/lease and remote head, then record an explicit continuation binding to PR6. Do not let issue/N default routing create a duplicate pilot branch or PR.
  • Independently review the actual pilot diff and update stale descriptions without claiming the earlier run covers later edits; inventory workflow/test source identities and pin reviewed reusable dependencies.
  • Reconcile PR6's bounded requirements: deployed image identity, nonzero persistent-data checks and cleanup; produce exact-head review/evidence and remaining qualification gaps.
  • Prepare the thin consumer integration needed after separately authorized landing; retain failure-only and real blockers until reviewed full applicable gates exist.
  • Use keep: competitor perf-gate -- vs Redis / Dragonfly / KeyDB / Garnet (arena, ratchet) #2/PR10 for the existing performance ratchet and Linux baseline gap; preserve intentional Refs keep: competitor perf-gate -- vs Redis / Dragonfly / KeyDB / Garnet (arena, ratchet) #2 and Refs keep: KV store -- redis/dragonfly replacement (epic) #1 on PR10/11 because those parent requirements remain incomplete.
  • Local validation is affected isolated unit/static; full applicable tests run online through the authorized normal path, not local cluster work.

Scheduling

P1 in keep@0.5.0; not todo until original PR continuation and owner release are proven. This issue is the missing pilot tracking contract, not permission to merge/rename branches, dispatch CI, create resources, alter AW/credentials/permissions or clear holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions