Repository navigation
raft-runtime: pin into_result storage-over-phase precedence with a test row - #71
Open
chrischeng-c4 wants to merge 1 commit into
Open
chrischeng-c4 wants to merge 1 commit into
chrischeng-c4 wants to merge 1 commit into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Changes
report_into_result_prefers_storage_failure_over_incomplete_phaseincrates/raft-runtime/tests/it/host_shutdown_deadline.rsnext toreport_into_result_returns_distinct_err_naming_phase_for_all_incomplete_phases.HostShutdownReportliteral with bothstorage_failure: Some(_)andincomplete_phase: Some(_), callsinto_result(), and asserts that the resulting error renders the storage failure string rather than the incomplete phase error message.crates/raft-runtime/src/.Negative Control
if letbranches inHostShutdownReport::into_result(crates/raft-runtime/src/application/host/shutdown_report.rs:60-67).host_shutdown_deadline::report_into_result_prefers_storage_failure_over_incomplete_phasefailed (assertion 'left == right' failed: left: "raft: shutdown stopped early in phase Quiesce", right: "durable storage failed for node 1 on write_entry at /var/data/raft/wal: Other"), whilereport_into_result_returns_distinct_err_naming_phase_for_all_incomplete_phasespassed.shutdown_report.rs.Local Validation Passed
cargo test --locked -p raft-runtime --test it host_shutdown_deadline::report_into_result_prefers_storage_failure_over_incomplete_phase -- --exact(1 passed, 0 failed).cargo test --locked -p raft-runtime --test it host_shutdown_deadline::report_into_result_returns_distinct_err_naming_phase_for_all_incomplete_phases -- --exact(1 passed, 0 failed).rustfmt --edition 2021 --check crates/raft-runtime/tests/it/host_shutdown_deadline.rs(passed).Cloud MR Validation Required (Not Run Locally)
itbinary (e.g. cluster timeouts, raft elections, server listeners): NOT RUN locally per test policy; delegated to authorized cloud CI.