Repository navigation
feat(gke-test): name every pool <repo>-<role> - #35
Merged
Merged
Conversation
Every pools.yaml row now sets `pool`, and Terraform refuses a name that is not `<repo>-<role>`. The server pool of a repository is `<repo>-server`, so it pairs with `<repo>-client` and the role is clear from the name. Renamed: keep -> keep-server, lumen -> lumen-server, lumen-perf -> lumen-perf-server. A rename destroys the old pool and creates the new one; both are at 0 nodes when no test runs.
chrischeng-c4
marked this pull request as draft
October 15, 2026 15:59
chrischeng-c4
marked this pull request as ready for review
October 15, 2026 16:42
2 of 3 tasks
chrischeng-c4
added a commit
to faberline/lumen
that referenced
this pull request
Oct 15, 2026
Select the lumen-perf-server pool for the GKE perf server faberline/aw#35 names every pool <repo>-<role> and replaced the lumen-perf pool with lumen-perf-server, so the gke-perf StatefulSet now selects and tolerates that pool. The client pool, lumen-perf-client, keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrischeng-c4
added a commit
to faberline/lumen
that referenced
this pull request
Oct 15, 2026
faberline/aw#35 names every pool <repo>-<role>, so pool-lumen becomes pool-lumen-server. The overlay's pool placement, the lumen-op CR's placement, and the pool checks in e2e.sh and verify.sh follow it. lumen-client keeps its name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrischeng-c4
added a commit
to faberline/keep
that referenced
this pull request
Oct 15, 2026
The check moves from a runner script with a port-forward to the Job in k8s/gke-test-job/ on pool-keep-client, so the client never takes CPU from the keep server. The server runs on pool-keep-server, with one replica per node (topologySpreadConstraints). Needs faberline/aw#35 applied first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
infra/gke-test/pools.yamlrow now setspool. Terraform refuses a name that is not<repo>-<role>.<repo>-server, so it pairs with<repo>-client.keep→keep-server,lumen→lumen-server,lumen-perf→lumen-perf-server.run.shmaps pools by.poolonly. The docs and the keep overlay example use the new names.Plan
The pools are at 0 nodes when no test runs. Apply only when no test namespace is live (
kubectl get ns -l faberline.dev/test-run).Follow-up in other repositories
keep-server.lumenorlumen-perfchange tolumen-serverandlumen-perf-server.Merge and apply this before those overlays run, or their pods stay Pending.
Checks
terraform fmt -check,terraform validate: pass.shellcheck -S warning scripts/gke-test/*.sh: pass.terraform plan: as above. Not applied.🤖 Generated with Claude Code