Skip to content

feat(gke-test): name every pool <repo>-<role> - #35

Merged
chrischeng-c4 merged 1 commit into
mainfrom
claude/gke-test-pool-roles
Oct 15, 2026
Merged

chrischeng-c4 merged 1 commit into
mainfrom
claude/gke-test-pool-roles

Conversation

@chrischeng-c4

Copy link
Copy Markdown
Contributor

Summary

  • Every infra/gke-test/pools.yaml row now sets pool. Terraform refuses a name that is not <repo>-<role>.
  • The server pool is <repo>-server, so it pairs with <repo>-client.
  • Renamed: keep → keep-server, lumen → lumen-server, lumen-perf → lumen-perf-server.
  • run.sh maps pools by .pool only. The docs and the keep overlay example use the new names.

Plan

google_container_node_pool.repo["keep"]              destroy
google_container_node_pool.repo["lumen"]             destroy
google_container_node_pool.repo["lumen-perf"]        destroy
google_container_node_pool.repo["keep-server"]       create
google_container_node_pool.repo["lumen-server"]      create
google_container_node_pool.repo["lumen-perf-server"] create
Plan: 3 to add, 0 to change, 3 to destroy.

The pools are at 0 nodes when no test runs. Apply only when no test namespace is live (kubectl get ns -l faberline.dev/test-run).

Follow-up in other repositories

Merge and apply this before those overlays run, or their pods stay Pending.

Checks

  • terraform fmt -check, terraform validate: pass.
  • shellcheck -S warning scripts/gke-test/*.sh: pass.
  • terraform plan: as above. Not applied.

🤖 Generated with Claude Code

Every pools.yaml row now sets `pool`, and Terraform refuses a name that is
not `<repo>-<role>`. The server pool of a repository is `<repo>-server`, so
it pairs with `<repo>-client` and the role is clear from the name.

Renamed: keep -> keep-server, lumen -> lumen-server,
lumen-perf -> lumen-perf-server. A rename destroys the old pool and creates
the new one; both are at 0 nodes when no test runs.
@chrischeng-c4
chrischeng-c4 marked this pull request as draft October 15, 2026 15:59
@chrischeng-c4
chrischeng-c4 marked this pull request as ready for review October 15, 2026 16:42
@chrischeng-c4
chrischeng-c4 merged commit cca145f into main Oct 15, 2026
chrischeng-c4 added a commit to faberline/lumen that referenced this pull request Oct 15, 2026
Select the lumen-perf-server pool for the GKE perf server

faberline/aw#35 names every pool <repo>-<role> and replaced the
lumen-perf pool with lumen-perf-server, so the gke-perf StatefulSet
now selects and tolerates that pool. The client pool,
lumen-perf-client, keeps its name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrischeng-c4 added a commit to faberline/lumen that referenced this pull request Oct 15, 2026
faberline/aw#35 names every pool <repo>-<role>, so pool-lumen becomes
pool-lumen-server. The overlay's pool placement, the lumen-op CR's
placement, and the pool checks in e2e.sh and verify.sh follow it.
lumen-client keeps its name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrischeng-c4 added a commit to faberline/keep that referenced this pull request Oct 15, 2026
The check moves from a runner script with a port-forward to the Job in
k8s/gke-test-job/ on pool-keep-client, so the client never takes CPU from
the keep server. The server runs on pool-keep-server, with one replica per
node (topologySpreadConstraints). Needs faberline/aw#35 applied first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant