Repository navigation
feat(cli): self-contained aexp binaries, install script and binary adoption proof (story 29.3) - #238
Merged
Merged
Conversation
…ry adoption proof (story 29.3) The release attaches single-file, self-contained aexp binaries for linux-x64, linux-arm64, osx-arm64, osx-x64 and win-x64 with SHA256SUMS (sums quoted in the notes), built by eng/publish-binaries.sh from a locked restore of the Cli project's own binaries lock file, so the tool package is untouched. scripts/install-aexp.sh (curl | sh) picks the binary for the machine, verifies its sum and puts it on PATH. CI builds the same binaries on every pull request and proves each on its own runner with no .NET installed, through the install script (a corrupted sum refused first) and the 29.2 adoption-path checks. WorkflowTests pin the jobs, the release rules and the scripts. The README leads with the path that needs no .NET. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 29.3 of Epic 29 (reach without a .NET toolchain):
aexpwithout the .NET SDK.What
eng/publish-binaries.shbuilds single-file, self-containedaexpfor linux-x64, linux-arm64, osx-arm64, osx-x64 and win-x64 from a locked restore of the Cli project's ownpackages.binaries.lock.json(conditional onAexpBinaries, so a plain build, restore or pack never sees it and the tool package is byte-for-byte unchanged;verify-packagesstill passes). No trimming or AOT.verifybuilds and checks them (six files,sha256sum --check --strict, the Linux binary prints the tagged version), appends a## Binariessection with the sums to the notes, and uploads them;publishchecks the sums again and attaches them to the GitHub release (a re-run completes an existing release's assets with--clobber).scripts/install-aexp.sh(curl -fsSL .../main/scripts/install-aexp.sh | sh, POSIX sh): detects the platform, picks the newest release (AEXP_VERSIONpins one,AEXP_DOWNLOAD_BASEreplaces the release URL), verifies the SHA-256 sum againstSHA256SUMSbefore installing anything, putsaexpin~/.local/bin(AEXP_INSTALL_DIR).eng/prove-adoption-path.sh --binaries <dir>runs the install script against a localfile://base (a copy with a corrupted sum first, which must install nothing), then the 29.2 checks, with nodotnetcall. CI: jobbinariesplus fiveadoption-path-binary (<rid>)legs onubuntu-24.04,ubuntu-24.04-arm,macos-15,macos-15-intel,windows-2025, none with the SDK installed.WorkflowTests: the two CI jobs, the release rules (19 new mutation rows), the scripts (executable, runtimes equal to the csproj's list, sum checked beforemv).Review
One edge-case reviewer: 17 findings, 4 patched (install script: empty version after a failed
--version, a leadingvinAEXP_VERSION, a rawmvfailure, the rate-limit message), the rest false or rejected with evidence; nothing deferred.After merge
The binaries exist from the first release after this change; until then the install script fails naming the missing asset. The five legs and
binariesjoin the required checks after the first green run onmain.🤖 Generated with Claude Code