Skip to content

ci: prove the adoption path from the packed tool on Linux, macOS and Windows (story 29.2) - #237

Merged
fabbrik merged 3 commits into
mainfrom
feat/29-2-adoption-path-in-ci
Nov 14, 2026
Merged

fabbrik merged 3 commits into
mainfrom
feat/29-2-adoption-path-in-ci

Conversation

@fabbrik

@fabbrik fabbrik commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Story 29.2 of Epic 29 (Reach Without a .NET Toolchain). No change under src/.

  • eng/prove-adoption-path.sh: installs aexp as a global tool from the packed .nupkg only (--source <dir>, at the version scripts/release-version.sh derives, so nuget.org cannot stand in), then on a scratch project runs aexp init --verify, aexp trust (approval written to a config dir inside the scratch dir), a run the verifier fails and a run it passes, and asserts that finalize, recall, lessons and benefit print what the README promises. Uninstalls the tool and removes the scratch dir on exit; refuses to run over an existing global install.
  • adoption-path (ubuntu-24.04 | macos-15 | windows-2025): a new CI job after pack that downloads the packages artifact and runs the script under shell: bash, 20-minute timeout, no softener. After this merges, the three legs join main's required status checks.
  • WorkflowTests: a fact pinning the job's shape (needs pack, the three runners, the artifact, the script, no continue-on-error, no permissions) and the script's presence, mode and install command.
  • .gitattributes: *.sh text eol=lf, so the Windows checkout keeps the scripts bash can run.
  • CONTRIBUTING, the CLI guide and the CHANGELOG name the job.

Locally (macOS): the script passes its 16 checks against a local pack and leaves no global tool behind; a mutation that never creates fixed fails at the verified-run check. The three runner legs are the acceptance test for the workflow itself.

🤖 Generated with Claude Code

fabbrik and others added 3 commits November 14, 2026 16:37
…Windows (story 29.2)

eng/prove-adoption-path.sh installs AgentExperience.Cli as a global tool
from the .nupkg CI packed for the same commit (never from nuget.org),
then on a scratch project runs aexp init and aexp trust, finalizes a run
the verifier fails and one it passes, and asserts what recall, lessons
and benefit print. The adoption-path job runs it on ubuntu-24.04,
macos-15 and windows-2025 from the pack job's artifact, so every OS
proves the same bytes. A release test pins the job and the script.
*.sh files are LF on every checkout so the Windows runner's bash can
run them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…LF and a locked scratch dir

Review round 1: an aexp_ok output used inline as an argument lost its
exit status (a crashing recall passed the emptiness check vacuously), so
every output is assigned first; the Windows SDK assert strips the CR;
the cleanup trap warns instead of aborting when the scratch dir cannot
be removed; the already-installed check no longer depends on a pipeline
grep -q may close early; the tools dir honours DOTNET_CLI_HOME.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@fabbrik
fabbrik merged commit 2a58578 into main Nov 14, 2026
26 checks passed
@fabbrik
fabbrik deleted the feat/29-2-adoption-path-in-ci branch November 14, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant