Repository navigation
ci: prove the adoption path from the packed tool on Linux, macOS and Windows (story 29.2) - #237
Merged
Merged
Conversation
…Windows (story 29.2) eng/prove-adoption-path.sh installs AgentExperience.Cli as a global tool from the .nupkg CI packed for the same commit (never from nuget.org), then on a scratch project runs aexp init and aexp trust, finalizes a run the verifier fails and one it passes, and asserts what recall, lessons and benefit print. The adoption-path job runs it on ubuntu-24.04, macos-15 and windows-2025 from the pack job's artifact, so every OS proves the same bytes. A release test pins the job and the script. *.sh files are LF on every checkout so the Windows runner's bash can run them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…LF and a locked scratch dir Review round 1: an aexp_ok output used inline as an argument lost its exit status (a crashing recall passed the emptiness check vacuously), so every output is assigned first; the Windows SDK assert strips the CR; the cleanup trap warns instead of aborting when the scratch dir cannot be removed; the already-installed check no longer depends on a pipeline grep -q may close early; the tools dir honours DOTNET_CLI_HOME. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story 29.2 of Epic 29 (Reach Without a .NET Toolchain). No change under
src/.eng/prove-adoption-path.sh: installsaexpas a global tool from the packed.nupkgonly (--source <dir>, at the versionscripts/release-version.shderives, so nuget.org cannot stand in), then on a scratch project runsaexp init --verify,aexp trust(approval written to a config dir inside the scratch dir), a run the verifier fails and a run it passes, and asserts thatfinalize,recall,lessonsandbenefitprint what the README promises. Uninstalls the tool and removes the scratch dir on exit; refuses to run over an existing global install.adoption-path (ubuntu-24.04 | macos-15 | windows-2025): a new CI job afterpackthat downloads thepackagesartifact and runs the script undershell: bash, 20-minute timeout, no softener. After this merges, the three legs joinmain's required status checks.WorkflowTests: a fact pinning the job's shape (needs pack, the three runners, the artifact, the script, nocontinue-on-error, nopermissions) and the script's presence, mode and install command..gitattributes:*.sh text eol=lf, so the Windows checkout keeps the scripts bash can run.Locally (macOS): the script passes its 16 checks against a local pack and leaves no global tool behind; a mutation that never creates
fixedfails at the verified-run check. The three runner legs are the acceptance test for the workflow itself.🤖 Generated with Claude Code