fix(auth): faable auth gestiona un tenant con su token de gestión, no con el de faable login - #11
Merged
Merged
Conversation
…no con el de faable login `faable auth clients|actions|logs` mandaba el token de `faable login` (usuario de la cuenta raíz) contra el tenant: solo funcionaba porque auth trataba ese token como superadmin de plataforma, y la fase 3 del aislamiento multi-tenant lo quita. Ahora resuelve el tenant (--account, o el host de --auth-url por la ruta pública /account/host/:host), pide a la api POST /auth-accounts/:id/token (que comprueba la pertenencia) y usa ese token. Si la api no emite uno (tenant de plataforma, 404/501/503 o sin red), sigue con el de sesión como antes; un 403 (no eres miembro) es un error.
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloqueaba la fase 3 de
arch/auth/management-api-tenant-isolation.md: la telemetría (mgmt_authz_platform_use) mostró quefaable-clihacíaclient:create/client:deleteen un tenant con el token de usuario raíz, que solo funciona mientras ese token sea «de plataforma».requireAuthAdminresuelve el tenant:--accounto, si no, el host de--auth-urlpor la ruta pública/account/host/:host.POST /auth-accounts/:id/tokena la api (comprueba la pertenencia) y usa ese token.Tests: 6 nuevos (
auth_admin.test.ts), 185 ✔. Red run: sin el caso 403, 2 en rojo.