Repository navigation
Add unit tests to CI workflow - #33
Merged
Merged
Conversation
- Add 'test' job to msbuild.yml that builds and runs unit tests on ubuntu-latest - Fix NOTIFYICONDATA redefinition between mock windows.h and shellapi.h - Add *.o and tests/test_runner to .gitignore Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
testjob to the existingmsbuild.ymlCI workflow that builds and runs the unit tests onubuntu-latestusing g++ with mock Windows headers.Changes:
.github/workflows/msbuild.yml— newtestjob that runsmake allandmake testin thetests/directorytests/mock/windows.h— removed emptyNOTIFYICONDATAstub to fix redefinition conflict withshellapi.hmock.gitignore— added*.oandtests/test_runnerto prevent test build artifacts from being committedThe test job runs in parallel with the existing
buildjob and does not block releases.Review & Testing Checklist for Human
testCI check appears and passes on PRsbuildandreleasejobs still work as beforeNotes
Link to Devin session: https://app.devin.ai/sessions/b12cb4073e064845a826beb32e332637
Requested by: @fL0P1337