Repository navigation
Re-apply Enhancement branch with resolved merge conflicts - #32
Merged
Merged
Conversation
Resolved merge conflicts in: - AppWindow.cpp: Fixed includes and added WM_INPUT raw input handling - InterceptionBackend.cpp: Use LoadLibraryExW with secure flags (nullptr) - gui/GuiManager.cpp: Use LoadLibraryExW with secure flags (nullptr) - tests/mock/windows.h: Unified all mock types and functions - tests/mock/tchar.h: Unified mock definitions - tests/mock/Utils.h/.cpp: Combined mock implementations - tests/test_SuperglideLogic.cpp: Use run_superglide_tests() entry point - tests/Makefile: Unified build targets Changes from the enhancement branch: - Replace side-mouse polling thread with Raw Input API - Fix DLL hijacking via LoadLibraryExW with restricted search paths - Optimize Config.cpp string operations (pass by const ref) - Support hex/octal in ParseKeyValue via std::stoi base=0 - Remove redundant comments on includes - Remove commented-out constants in globals.h - Add Globals.h symlink - Add unit tests for SuperglideLogic, Utils, and Config - Update combine.yml: use proper merge strategy and devops-infra action - Exclude binary artifacts (.o files, test_runner) Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-applies all changes from the
enhancementbranch (PR #30, commit d3192ec) with all merge conflicts properly resolved and binary artifacts removed.Root cause of original failure: The enhancement branch was created by merging ~16 feature branches together, but several merges left unresolved conflict markers (
<<<<<<<,=======,>>>>>>>) in the source code. This caused MSVC compilation errors on CI.Conflicts resolved:
AppWindow.cpp— 4 nested conflicts in includes section; resolved to include<vector>and<windows.h>(no comments)InterceptionBackend.cpp—nullptrvsNULLinLoadLibraryExW; resolved tonullptr(modern C++)gui/GuiManager.cpp— samenullptrvsNULLconflict; resolved tonullptrtests/mock/windows.h— 45 conflict markers from 6+ branches; unified into clean mock header with all needed types/macrostests/mock/tchar.h— 18 conflict markers; unified to include all needed definestests/mock/Utils.h/Utils.cpp— unified mock implementationstests/test_SuperglideLogic.cpp—main()vsrun_superglide_tests()entry point conflicttests/Makefile— 6 conflicting build configurations; unified into single targetcombine.yml— fixedtarget_branchfrommaintomaster(matches actual default branch)Junk files excluded (were in the enhancement branch but shouldn't be committed):
commit_message.txt,fix_linkage.py,pr.txt.ofiles andtest_runnerexecutabletests/mock/windows_mock.cpp(duplicated inline functions now in header)Feature changes preserved from enhancement:
LoadLibraryExWwithLOAD_LIBRARY_SEARCH_DLL_LOAD_DIRConfig.cppstring ops (const ref params)ParseKeyValueviastd::stoi(_, nullptr, 0)// <-- Addcomments on includesglobals.hGlobals.hsymlink for case-sensitive filesystemscombine.ymlmerge strategyReview & Testing Checklist for Human
LoadLibraryExWwith restricted search paths may behave differently if DLL is not in the exe directorydevops-infra/action-pull-requestreplacespeter-evans/create-pull-requestNotes
grepscancombine.ymlwas fixed to targetmasterinstead ofmain(the enhancement branch hadmainwhich is incorrect for this repo)Link to Devin session: https://app.devin.ai/sessions/b12cb4073e064845a826beb32e332637
Requested by: @fL0P1337