fix: downmix multi-channel audio to mono for SFSpeechRecognizer#32
Open
chrishutchins wants to merge 1 commit intof:masterfrom
Open
fix: downmix multi-channel audio to mono for SFSpeechRecognizer#32chrishutchins wants to merge 1 commit intof:masterfrom
chrishutchins wants to merge 1 commit intof:masterfrom
Conversation
SFSpeechRecognizer silently returns no results when receiving multi-channel audio buffers. USB audio interfaces like the RODECaster Pro II send 2-channel 48kHz audio, and the previous `format: nil` tap delivered these buffers unchanged to the recognition request. Create a mono AVAudioFormat at the hardware sample rate when the device has more than one channel and pass it to installTap, letting AVAudioEngine handle the downmix automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem:
SFSpeechRecognizersilently returns no results when receiving multi-channel audio buffers. USB audio interfaces like the RODECaster Pro II send 2-channel 48kHz audio, and the previousformat: niltap delivered these buffers unchanged to the recognition request. The waveform visualization works fine (it only reads channel 0), but the recognizer never fires its result callback.Fix: When the input device has more than one channel, create a mono
AVAudioFormatat the hardware sample rate and pass it toinstallTap.AVAudioEnginehandles the downmix automatically. Single-channel devices (e.g. built-in mic) are unaffected.Test plan
🤖 Generated with Claude Code