Fix: Keep text visible after WPM auto-scroll reaches the end#30
Open
ecwilsonaz wants to merge 3 commits intof:masterfrom
Open
Fix: Keep text visible after WPM auto-scroll reaches the end#30ecwilsonaz wants to merge 3 commits intof:masterfrom
ecwilsonaz wants to merge 3 commits intof:masterfrom
Conversation
In Classic and Voice-Activated modes, the overlay would immediately switch to a "Done" screen and auto-dismiss 1 second after the auto-scroll reached the last word. This made timed mode unusable because speakers typically finish talking 10-20 seconds after the scroll ends. Now in timer-based modes (Classic/Voice-Activated), when the scroll reaches the end on the last page: - The prompter text stays visible instead of switching to "Done" - The overlay does not auto-dismiss - The speaker can close manually via the X button or Esc key Word Tracking mode behavior is unchanged (auto-dismiss is appropriate there since it knows when the speaker actually finishes). Fixes f#29
Address code review findings: - ExternalDisplayView: gate doneView and speechRecognizer.stop() on wordTracking mode, matching NotchOverlayView/FloatingOverlayView - BrowserServer: suppress isDone in classic/silencePaused modes on last page so browser clients keep showing prompter text - Revert accidental DEVELOPMENT_TEAM change in project.pbxproj
The timerWordProgress was incrementing unboundedly after the scroll reached the end, unlike the SwiftUI views which guard with !isDone. Add a scrollDone check before incrementing to stop wasting CPU on the 100ms broadcast timer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29
In Classic and Voice-Activated (silence-paused) modes, the overlay would immediately switch to a "Done!" screen and auto-dismiss 1 second after the auto-scroll reached the last word. This made timed mode unusable because speakers typically finish talking 10–20 seconds after the scroll ends.
Now in timer-based modes (Classic/Voice-Activated), when the scroll reaches the end on the last page:
Word Tracking mode behavior is unchanged (auto-dismiss is appropriate there since it knows when the speaker actually finishes).
Changes
doneViewand auto-dismiss onlisteningMode == .wordTrackingin bothNotchOverlayViewandFloatingOverlayViewExternalDisplayView(fullscreen and external display)isDonein the WebSocket state for classic/silencePaused on the last page; also stoptimerWordProgressfrom advancing after scroll completesTest plan