Refactor: 메시지 처리 코드 리팩토링 - #43
Open
ghost wants to merge 1 commit into
Open
Conversation
ghost
requested a review
from f-lab-evan
March 31, 2022 12:57
ghost
force-pushed
the
feature/40
branch
2 times, most recently
from
April 3, 2022 08:53
835a395 to
bac038b
Compare
f-lab-evan
suggested changes
Apr 5, 2022
f-lab-evan
left a comment
f-lab-evan
left a comment
There was a problem hiding this comment.
동일 이름의 커밋이 중복으로 올라와 있네요. 하나로 합쳐야 할것 같습니다
| import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule; | ||
| import com.flab.planb.response.message.MessageLookup; | ||
| import org.springframework.context.MessageSource; | ||
| import org.springframework.context.annotation.Configuration; |
| messageLookup.getMessage(exceptionType.getLookupKey()), | ||
| Map.of("errorCode", exceptionType.getCode())))); | ||
| } catch (IOException e) { | ||
| log.error("{}", e.getMessage()); |
Author
There was a problem hiding this comment.
클라이언트 응답은 ResponseMessage에서 만들고 write로 보내도록 하고 있습니다. 이로 인해 resolveException 메서드에서 ModelAndView를 반환할 필요가 없다고 생각해 null을 반환하도록 했지만, 비어있는 객체를 반환하도록 수정했습니다.
ghost
force-pushed
the
feature/40
branch
2 times, most recently
from
April 5, 2022 04:05
e688928 to
1df3272
Compare
- EnumSet 제거 및 Array.stream 사용 Resolves: #40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
Issues : #40
1. 메시지 처리 코드 리팩토링
리뷰 가이드
1. 메시지 처리 코드 리팩토링