feat: first pass at removing requirement to inherit directly from ez.…#177
Draft
feat: first pass at removing requirement to inherit directly from ez.…#177
Conversation
…State and ez.Settings. fix: remove accidental import.
pperanich
force-pushed
the
refactor-state-settings-check
branch
from
dd2b581 to
336c338
Compare
Collaborator
|
@pperanich and I chatted about this PR; it might make sense to redo parts of this PR to not even require dataclasses for state/settings. Some feedback we got from other users indicate that people would like to use Pydantic or Param data structures that enforce bounds on settings, for example. I would like to add additional checks/features if users do choose to use dataclasses, but not require it if they want to try their luck with other data structures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at removing the requirement that a Unit's
SETTINGSandSTATEinherit directly fromez.Settingsandez.State, respectively. Instead, forSETTINGS, we ensure the type is a frozen dataclass, and forSTATE, we ensure the type is a dataclass.