Skip to content

Hologram clear subcommand - #43

Open
ez-plugins wants to merge 13 commits into
mainfrom
fix/hologram-removal
Open

Hologram clear subcommand#43
ez-plugins wants to merge 13 commits into
mainfrom
fix/hologram-removal

Conversation

@ez-plugins

Copy link
Copy Markdown
Owner
  • Hologram placement & removal — rewrote the TextDisplay hologram platform to use the typed Paper API directly. Previously a NamespacedKey(JavaPlugin, String) lookup threw and was swallowed, so the PDC marker was never written and holograms could not be detected or removed. Holograms are now correctly tagged, re-attached after restarts, and persistent.
  • Hologram removal flow/auctionhologram now supports list [radius] [--untagged], clear [radius] [--untagged] (alias remove), and clearall [radius] [--untagged]. Tagged clear removes the nearest EzAuction hologram immediately; clearall and any --untagged clear use two-step confirmation. Search uses the player's eye location and the new removal-radius config (default 10 blocks) instead of the placement-only search-radius.
  • Safer clear --untagged — removing untagged displays (which also match other plugins' TextDisplays) now requires a second run within 15 seconds. The first run reports how many untagged displays are in range; the second removes only the nearest one, so a stray bulk delete of another plugin's holograms is avoided.
  • Placement confirmation shows coordinates — the success message for /auctionhologram <type> now reports the exact spawn coordinates and world (e.g. Placed … hologram at 12,66,-4 (world)), matching where the hologram actually landed (the targeted block plus the configured height-offset).
  • Existing orphans stay orphaned — holograms placed before this fix carry no marker; reach them with --untagged (also matches other plugins' TextDisplays). Run list --untagged before clear --untagged.
  • Hardened — spherical distance filtering for removal, removed a latent ConcurrentModificationException in the update loop, and made max-holograms enforcement live with a distinct denial message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants