Hologram clear subcommand - #43
Open
ez-plugins wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NamespacedKey(JavaPlugin, String)lookup threw and was swallowed, so the PDC marker was never written and holograms could not be detected or removed. Holograms are now correctly tagged, re-attached after restarts, and persistent./auctionhologramnow supportslist [radius] [--untagged],clear [radius] [--untagged](aliasremove), andclearall [radius] [--untagged]. Taggedclearremoves the nearest EzAuction hologram immediately;clearalland any--untaggedclear use two-step confirmation. Search uses the player's eye location and the newremoval-radiusconfig (default 10 blocks) instead of the placement-onlysearch-radius.clear --untagged— removing untagged displays (which also match other plugins' TextDisplays) now requires a second run within 15 seconds. The first run reports how many untagged displays are in range; the second removes only the nearest one, so a stray bulk delete of another plugin's holograms is avoided./auctionhologram <type>now reports the exact spawn coordinates and world (e.g.Placed … hologram at 12,66,-4 (world)), matching where the hologram actually landed (the targeted block plus the configuredheight-offset).--untagged(also matches other plugins' TextDisplays). Runlist --untaggedbeforeclear --untagged.ConcurrentModificationExceptionin the update loop, and mademax-hologramsenforcement live with a distinct denial message.