Repository navigation
Install the skill through flux install claude in install.sh - #20
Merged
Merged
Conversation
v0.5.0 embeds the skill, so install.sh calls flux install claude instead of copying skill/SKILL.md, and release archives hold only the binary. SKILL_DIR is replaced by CLAUDE_CONFIG_DIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Install the Flux skill with flux install claude, omp or codex
v0.5.0(#19) embeds the skill in the binary.install.shnow installs the skill through that command instead of copying it from the release archive, so the skill matches the installed binary on every install path. This is step 2 ofdocs/specs/install-command.md. It could only merge afterv0.5.0was released, becauseinstall.shis served frommasterbut downloads the latest release.Changes
install.shruns"$INSTALL_DIR/flux" install claudeafter installing the binary, from both a release and a source build. If that fails (for example, a symlinked skill folder is refused), it prints a warning and keeps the binary.SKILL_DIRis gone;CLAUDE_CONFIG_DIRreplaces it, as forflux install claude.files: [none*]). Without afileslist, GoReleaser would addREADME.md.scripts/test-install.shno longer requiresskill/SKILL.mdin the archives. It still checks a fresh install, that an unchanged reinstall makes no backup, and that an edited skill is backed up, now throughflux install claude. It unsetsCLAUDE_CONFIG_DIRinstead ofSKILL_DIR.Compatibility
Anyone who exported
SKILL_DIRforinstall.shnow gets~/.claude/skills/flux; setCLAUDE_CONFIG_DIRto change it. Releases from now on no longer shipskill/SKILL.mdin the archives.flux updateonly extractsflux, so it is unaffected.Verification
goreleaser release --snapshot --clean(v2.18.3), thenscripts/test-install.sh dist: all four archives contain onlyflux; the install, no-backup and backup checks pass.install.shagainst the publishedv0.5.0release, under a temporaryHOME: it downloadedv0.5.0and installed the binary and a skill identical toskill/SKILL.md.~/.claude/skills/flux,install.shprinted the warning, left the link target untouched, kept the binary and exited 0.