externpro 26.01.1-41-g49be750#8
Merged
Merged
Conversation
Replace variable CMAKE_NAMESPACE with hardcoded protobuf namespace for all
targets and update debug postfix to use protobuf-specific variable.
Changes:
- Use protobuf:: namespace for all target aliases and exports instead of ${CMAKE_NAMESPACE}
- Set protobuf_DEBUG_POSTFIX from CMAKE_DEBUG_POSTFIX if defined, otherwise default to "d"
- Update all library targets (libprotobuf-lite, libprotobuf, libprotoc) to use protobuf_DEBUG_POSTFIX
- Update protobuf-config.cmake.in and protobuf-module.cmake.in to use protobuf:: targets
- Update examples to link against protobuf::libprotobuf
This ensures consistent target naming across the protobuf package and
allows external control of debug postfix via CMAKE_DEBUG_POSTFIX (defined by externpro).
- Several of these changes (using protobuf:: namespace especially) now match the upstream cmake, reducing the number of changes in the patch of this project
- These changes follow the direction that the Package Name and Target Namespace should match as described in issue externpro/externpro#307
- Update minimum CMake version from 3.31 to 4.3 - Remove XP_NAMESPACE and xproinc.cmake inclusion (now part of CMakePresets) - add CMAKE_EXPERIMENTAL_GENERATE_SBOM in presets - Package name and Target Namespace now match - Make xpExternPackage conditional 'if(COMMAND' and move to end of CMakeLists.txt - Repo's protobuf-config installed as protobuf-config-orig - see externpro/externpro#308 (comment) - avoid collision with xpExternPackage() installed protobuf-config - Auto-infer dependencies (zlib) - Add FIND_XPRO_CMAKE to force cmake script mode instead of CPS for this package because of CMake Warning detailed below CMake Warning in [...]/share/cps/protobuf.cps: component "protobuf::protoc" has unknown type "executable" and was not imported
smanders
added
dependencies
Collaborator
Author
|
issue externpro/externpro#322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update externpro submodule to
26.01.1-41-g49be750Changes
.devcontainerto externpro26.01.1-41-g49be7500ac4bac86f2f25110dcf941fb94820bd79c061ec49be7504e19dbad58d8166f98ef0c14b942ea58bxprodeps.md.github/release-tag.json(tag:xpv3.14.0.6)Workflow Update Report
CMakePresets.json
.devcontainer/cmake/presets/xpWindowsVs2022.jsoninclude and stagedCMakePresets.jsonThis PR was created automatically by GitHub Actions