Skip to content

fix: update default view engine from jade to pug #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RushilJalal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update default view engine from jade to pug #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/express-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ function main (options, done) {
if (options.view === true) {
warning('the default view engine will not be jade in future releases\n' +
Copy link
Member

@IamLizu IamLizu Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary warning if jage is no longer the default.

Copy link
Author

@RushilJalal RushilJalal Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove this warning completely?

"use `--view=jade' or `--help' for additional options")
options.view = 'jade'
options.view = 'pug'
}

// Generate application
Expand Down
4 changes: 3 additions & 1 deletion test/cmd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ describe('express(1)', function () {
' "debug": "~2.6.9",\n' +
' "express": "~4.17.1",\n' +
' "http-errors": "~1.7.2",\n' +
' "jade": "~1.11.0",\n' +
// replace default jade with pug
// ' "jade": "~1.11.0",\n' +
' "pug": "~3.0.3",\n' +
Copy link
Member

@IamLizu IamLizu Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incompatible version of pug

Copy link
Author

@RushilJalal RushilJalal Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the latest version of pug incompatible? Which version should it be instead?

' "morgan": "~1.10.0"\n' +
' }\n' +
'}\n')
Expand Down
Loading