Skip to content

[binary-search] Use null when no value is found #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsaacG merged 1 commit into from
Oct 3, 2026
Merged

[binary-search] Use null when no value is found #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/practice/binary-search/.meta/example.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ func find(search_list, value):
low = middle + 1
else:
return middle
return false
return null
2 changes: 1 addition & 1 deletion exercises/practice/binary-search/.meta/template.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
func test_{{ case.func_name }}(solution_script):
var got = solution_script.find({{ case.input.array }}, {{ case.input.value }})
{%- if case.expect_error %}
var want = false
var want = null
{%- else %}
var want = {{ case.expected }}
{%- endif %}
Expand Down
10 changes: 5 additions & 5 deletions exercises/practice/binary-search/binary_search_test.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,29 +36,29 @@ func test_finds_a_value_in_an_array_of_even_length(solution_script):

func test_identifies_that_a_value_is_not_included_in_the_array(solution_script):
var got = solution_script.find([1, 3, 4, 6, 8, 9, 11], 7)
var want = false
var want = null
return [got, want]


func test_a_value_smaller_than_the_array_s_smallest_value_is_not_found(solution_script):
var got = solution_script.find([1, 3, 4, 6, 8, 9, 11], 0)
var want = false
var want = null
return [got, want]


func test_a_value_larger_than_the_array_s_largest_value_is_not_found(solution_script):
var got = solution_script.find([1, 3, 4, 6, 8, 9, 11], 13)
var want = false
var want = null
return [got, want]


func test_nothing_is_found_in_an_empty_array(solution_script):
var got = solution_script.find([], 1)
var want = false
var want = null
return [got, want]


func test_nothing_is_found_when_the_left_and_right_bounds_cross(solution_script):
var got = solution_script.find([1, 2], 0)
var want = false
var want = null
return [got, want]
Loading