Conversation
|
Great job @erseco After the first tests:
- In certain situations, the edit button with eXe appears in places where it shouldn't.
|
|
Hi @pabloamayab I’ve made the requested corrections based on your previous review. Could you please check it again when you have a moment? Thanks. |
ignaciogros
left a comment
There was a problem hiding this comment.
Thank you for this great tool, @erseco.
I've been testing with Moodle 4.5.10 using the static editor.
If you add a new activity an click on "Save and display" you get this PHP error:
Exception - array_keys(): Argument #1 ($array) must be of type array, null given
The same error is displayed when you click con "Save and return" (it returns to the course) and then you click on the name of the activity to see it.
Apart from that, the "Edit in eXeLearning" button is visible when Moodle's "Edit mode" is off, but that's just a detail.
|
I suggest creating a new branch for this and integrating the development into this repository as soon as possible, so it's easier to contribute. |
I fixed this exception, please review again if you can





This pull request introduces several foundational improvements to the project, focusing on build automation, environment configuration, packaging, and editor integration. The most significant changes include the addition of a comprehensive
Makefilefor cross-platform development, a new GitHub Actions workflow for automated releases, environment variable management, packaging rules, and the initial implementation of a modal controller for the embedded eXeLearning editor.Build and Packaging Automation:
Makefileto automate Docker management, dependency installation, code linting, testing, static editor building, submodule management, and packaging into distributable ZIP files. The Makefile includes robust environment and Docker checks, OS detection, and help documentation..distignorefile to control which files and directories are excluded from the distributable package, ensuring clean and minimal releases..env.disttemplate file to document and manage required environment variables for local development and Docker Compose usage. (,R1-R21)Release Workflow:
.github/workflows/release.yml) to automate building the static editor, packaging the plugin, and uploading the ZIP file as a release asset whenever a new release is published.Editor Integration:
amd/src/editor_modal.js, which provides a modal overlay for the embedded eXeLearning editor. This includes fullscreen modal creation, save/close button handling, postMessage communication with the iframe editor, and integration with Moodle's string APIs and logging.exelearningsubmodule in.gitmodulespointing to the appropriate feature branch for the embedded static editor.These changes lay the groundwork for streamlined development, consistent packaging, and seamless integration of the embedded editor within the Moodle plugin.