Fix UI stack filters and pagination#2284
Draft
ejsmith wants to merge 19 commits into
Draft
Conversation
ejsmith
changed the title
niemyjski
reviewed
Jun 2, 2026
Comment on lines
+114
to
+127
| const previousPageInfo = pagination(); | ||
| const previousPageIndex = previousPageInfo.pageIndex; | ||
|
|
||
| setPagination(updaterOrValue); | ||
| const currentPageInfo = pagination(); | ||
| let currentPageInfo = pagination(); | ||
| const pageSizeChanged = previousPageInfo.pageSize !== currentPageInfo.pageSize; | ||
|
|
||
| if (pageSizeChanged && currentPageInfo.pageIndex !== 0) { | ||
| currentPageInfo = { | ||
| ...currentPageInfo, | ||
| pageIndex: 0 | ||
| }; | ||
| setPagination(currentPageInfo); | ||
| } |
Member
There was a problem hiding this comment.
This feels a bit hacky. this was working. We have three different table pagination strategies.
niemyjski
reviewed
Jun 2, 2026
|
|
||
| async function filterChanged(addedOrUpdated: IFilter) { | ||
| await redirectToEventsWithFilter(organization.current, addedOrUpdated); | ||
| const options = addedOrUpdated.type === 'string' && addedOrUpdated.key === 'string-stack' ? { time: null } : undefined; |
Member
There was a problem hiding this comment.
can this be a function that's documented, a lot of this stuff was hard to track down.
…ation' into codex/fix-ui-stack-filters-pagination
Member
Author
|
/preview |
1 similar comment
Member
Author
|
/preview |
github-actions
Bot
added
the
dev-preview
|
Preview deployed
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
User feedback surfaced several high-priority UI failures around stack deletion, event navigation, pagination, and chart rendering. The root cause for the event links was that route-level date/filter state was being recreated from partial query params; serialized filter controls now act as the source of truth, with the filter expression generated from them.
Impact
Breaking changes
None.
Validation
npm run checknpm run test:unit -- --run src/lib/features/events/components/filters/helpers.svelte.test.ts